Extract utility functions #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraravam
force-pushed
the
extract-utility-functions
branch
4 times, most recently
from
85a350c
to
34a12e1
Compare
SpecialAro
approved these changes
May 15, 2022
| if ( | ||
| workspace.services && | ||
| typeof workspace.services === 'string' && | ||
| workspace.services.length > 0 |
There was a problem hiding this comment.
This is no longer necessary?
There was a problem hiding this comment.
thanks - must have slipped my sight. will fix in new commit
There was a problem hiding this comment.
that's already handled in the convertJSON method
| if ( | ||
| workspace.data && | ||
| typeof workspace.data === 'string' && | ||
| workspace.data.length > 0 |
There was a problem hiding this comment.
that's already handled in the convertJSON method
| if ( | ||
| service.settings && | ||
| typeof service.settings === 'string' && | ||
| service.settings.length > 0 |
There was a problem hiding this comment.
that's already handled in the convertJSON method
vraravam
force-pushed
the
extract-utility-functions
branch
from
34a12e1
to
b08cdb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Description of Change
Extracted common utility functions related to JSON parsing
Will wait for #149 to be merged, and then put this up for review.
Motivation and Context
Remove code duplication
Screenshots
Checklist
npm run prepare-code)npm testpassesRelease Notes