Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair not working FAQ link #137

Merged
merged 1 commit into from
May 11, 2022
Merged

Repair not working FAQ link #137

merged 1 commit into from
May 11, 2022

Conversation

cm-schl
Copy link
Contributor

@cm-schl cm-schl commented May 11, 2022

old link pointed to a 404 site

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

simply removed a trailing slash to make the faq link work 😉

Motivation and Context

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

old link pointed to a 404 site
@vraravam vraravam merged commit c581c4d into ferdium:develop May 11, 2022
@vraravam
Copy link
Contributor

Thanks @cm-schl !

@vraravam
Copy link
Contributor

@all-contributors please add @cm-schl for doc

@allcontributors
Copy link
Contributor

@vraravam

I've put up a pull request to add @cm-schl! 🎉

@cm-schl cm-schl deleted the patch-1 branch May 11, 2022 10:28
@HenrijsS
Copy link

HenrijsS commented Jun 11, 2022

@vraravam Seems like this somehow popped back up.

@vraravam
Copy link
Contributor

@HenrijsS - the README.md still has the above fix. Where do you see this reverting?

1 similar comment
@vraravam
Copy link
Contributor

@HenrijsS - the README.md still has the above fix. Where do you see this reverting?

@HenrijsS
Copy link

HenrijsS commented Jun 15, 2022

@vraravam When creating a new GitHub issue.
There's the last option to view the FAQ.

There the last slash is throwing a 404.

(Seems like this was only in the Readme for the project)

@vraravam
Copy link
Contributor

Thanks for pointing those out - I have now fixed them as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants