Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Testing for url-helpers.ts #112

Merged
merged 3 commits into from
May 12, 2022
Merged

Add Unit Testing for url-helpers.ts #112

merged 3 commits into from
May 12, 2022

Conversation

amangalampalli
Copy link
Contributor

@amangalampalli amangalampalli commented May 7, 2022

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

I added a file called url-helpers.test.tsx to add unit tests to the Ferdium codebase.

Motivation and Context

This is one of the first unit tests in a series of strict tests that are useful automatic dependency upgrading and many others.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

Added unit tests to `url-helpers.tsx`

test/helpers/url-helpers.test.ts Outdated Show resolved Hide resolved
test/helpers/url-helpers.test.ts Outdated Show resolved Hide resolved
@vraravam vraravam marked this pull request as draft May 7, 2022 00:30
@vraravam
Copy link
Contributor

@amangalampalli - were you able to proceed further on this?

@amangalampalli
Copy link
Contributor Author

Really sorry, my final board exam is tomorrow, and I should be able to make more progress on it then, really sorry for any inconvenience!

src/preload-safe-debug.ts Outdated Show resolved Hide resolved
@vraravam vraravam marked this pull request as ready for review May 12, 2022 22:42
@vraravam vraravam merged commit cc3303c into ferdium:develop May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants