-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fix for fixing URLs with '//' #105
Conversation
7c20522
to
dcb007e
Compare
4255cba
to
7c7ab47
Compare
Unfortunately, the changes seem to break the app while bootup itself - I dont use Ferdium with any account, but the initial login screen itself doesn't come up for me. I'm unable to take this forward (have travel plans this weekend). If someone can continue and find the fix, i would really appreciate it |
Instead of fixing the URL everywhere we use it, I propose two alternatives approaches:
|
OMG! Thanks for catching the rabbit hole that I was digging! |
@nathanaelhoun - if you can review this and approve, we can merge for the next nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Pre-flight Checklist
Description of Change
Reverted previous fix from #103 and added new changes as per comment
Motivation and Context
Should now be a better fix for #102
Screenshots
Checklist
npm run prepare-code
)npm test
passesRelease Notes