Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update BlocObserver instances to use const constructors #3713

Conversation

ValentinVignal
Copy link
Contributor

Status

READY

Breaking Changes

NO

Description

Follows #3704 and relates to #3703

This PR updates all the bloc observers to have and use a const constructor.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@ValentinVignal
Copy link
Contributor Author

@felangel I named the PR refactor(bloc) but I'm not modifying the bloc package. I'm modifying bloc_test flutter_bloc, replay_bloc and several examples.
What title should I give to the PR?

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0458045) compared to base (c4500b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #3713    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           30        15    -15     
  Lines          709       328   -381     
==========================================
- Hits           709       328   -381     
Impacted Files Coverage Δ
packages/bloc_test/lib/src/bloc_test.dart 100.00% <100.00%> (ø)
...ackages/hydrated_bloc/lib/src/hydrated_cipher.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
packages/bloc_concurrency/lib/src/restartable.dart
packages/bloc/lib/src/bloc.dart
packages/bloc_concurrency/lib/src/droppable.dart
packages/bloc_concurrency/lib/src/sequential.dart
packages/bloc/lib/src/cubit.dart
packages/bloc/lib/src/emitter.dart
packages/bloc/lib/src/bloc_base.dart
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ValentinVignal ValentinVignal force-pushed the refactor/use-bloc-observer-const-constructor branch from 1c48222 to 199ddc3 Compare February 6, 2023 01:58
@felangel felangel added enhancement New feature or request example Example application labels Feb 6, 2023
@felangel felangel changed the title refactor(bloc): Use const constructor of bloc observer refactor: update BlocObserver instances to use const constructors Feb 6, 2023
@ValentinVignal
Copy link
Contributor Author

Thank you for the updates @felangel ! Do you need me to do anything else on this PR?

@felangel
Copy link
Owner

felangel commented Feb 6, 2023

Thank you for the updates @felangel ! Do you need me to do anything else on this PR?

Thank you! No, I think we’re all set — I’ll get this merged later today 👍

@felangel felangel merged commit 2577838 into felangel:master Feb 6, 2023
This was referenced Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request example Example application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants