-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves 122: add support for python bindings #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use scikit-build to build python wheel - transform runLaplacian into a class Laplacian
- add postprocessing measures
add notebook
add step build_wheel
The commit adds support for Python bindings by updating the workflows file, modifying the build_wheel and docs sections, and making changes to other files such as .gitignore, CMakeLists.txt, antora.yml, and nav.adoc. The build_wheel section now uses actions/checkout@v4 and includes additional steps for creating a virtual environment and compiling the wheel. The docs section also uses actions/checkout@v4 and includes steps for installing NPM and Python dependencies, building the Antora site, and deploying it using the JamesIves/github-pages-deploy-action. In addition, the commit updates the .gitignore file to include *.whl and /**/*.egg-info, modifies the CMakeLists.txt file to change the project name and version, updates the antora.yml file to include dynamic-blocks@ attribute, and modifies the nav.adoc file to add an Examples section with a Thermal Fin sub-section. Finally, the commit adds a new file, fin.adoc, under the examples directory, which provides a description and details about simulating heat transfer in a thermal fin. Refactor workflows file, build_wheel and docs sections, modify various files
prudhomm
added
📜 documentation
Improvements or additions to documentation
✨ enhancement
New feature or request
github_actions
Pull requests that update Github_actions code
🐍 python
labels
Nov 2, 2023
❌ Deploy Preview for feelpp-project-quiet-mochi-ba4d77 failed.
|
add support for python bindings #122
Add support for python bindings and update installation process This commit adds support for python bindings by adding a python library module, `_laplacian`, and linking it to the `pybind11` headers and `feelpp` library. The `VERSION_INFO` is set to the `PROJECT_VERSION` for the `_laplacian` module. The installation process is updated to install the `_laplacian` module if `SKBUILD_PROJECT_NAME` is present, otherwise, a python module `laplacian` is added and relevant files are installed to the appropriate directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github_actions
Pull requests that update Github_actions code
📜 documentation
Improvements or additions to documentation
🐍 python
✨ enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add python bindings
build wheel using scikit-build
update CI to use wheel package to generate the documentation
use python bindings to create dynamic documentation