Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): specify interface name #941

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

favonia
Copy link
Owner

@favonia favonia commented Sep 22, 2024

Close #713.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 68.26923% with 33 lines in your changes missing coverage. Please review.

Project coverage is 94.70%. Comparing base (2d95d69) to head (4bcc078).

Files with missing lines Patch % Lines
internal/provider/protocol/local_iface.go 44.00% 21 Missing and 7 partials ⚠️
internal/provider/protocol/local_auto.go 54.54% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   95.78%   94.70%   -1.09%     
==========================================
  Files          60       62       +2     
  Lines        2704     2775      +71     
==========================================
+ Hits         2590     2628      +38     
- Misses        104      129      +25     
- Partials       10       18       +8     
Flag Coverage Δ
unittests 94.70% <68.26%> (-1.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia force-pushed the specify-iface branch 4 times, most recently from 0b1545d to f47fcf5 Compare September 22, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify the ethernet interface for the local provider
1 participant