Added parameters for surface diffusion dependence #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
reviewed
Aug 1, 2024
schmoelder
requested changes
Aug 1, 2024
|
Soo, I did not mean to add the changes where I added the colloidal binding model to this branch, but git push did not work how I thought it was going to and that's what happened. Since some of the surface diffusivity parameters require having the colloidal binding model anyway and I don't know how to undo this without making an entirely new branch, I am just gonna go with it. |
schmoelder
force-pushed
the
add_GRM_surface_diffusion_dependence
branch
2 times, most recently
from
621fdce
to
c6e7351
Compare
schmoelder
force-pushed
the
add_GRM_surface_diffusion_dependence
branch
2 times, most recently
from
6b76e8a
to
eecef09
Compare
schmoelder
force-pushed
the
add_GRM_surface_diffusion_dependence
branch
from
7e8cea9
to
1807240
Compare
schmoelder
force-pushed
the
add_GRM_surface_diffusion_dependence
branch
from
1807240
to
92c2908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the parameters to allow surface diffusion dependence in the General Rate Model in the cadetAdapter and unitOperation files, which was discussed in this forum post. I copied the format of the original surface diffusivity parameter with the property and setter for all the new parameters, but am not sure if that was the correct way to do this as I am not familiar with these functions in python.
To do
createLWEmethods are merged intodev, i.e. wait until Add ports / MCT Model (new PR) #95 is merged).