-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go_auto_sameids causes gopls panic #2701
Comments
Thanks for reporting this. I was able to reproduce with |
Thanks, was just working out how to test it in |
Yep, definitely |
fatih/vim-go#2701 contains a report of a panic when finding references on a builtin. Avoid this by simply not returning any references. Change-Id: I195fcb4502634201888f0c65022c9d16169cc1f3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/218317 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
ok, I manually made the change from that, and now it is producing a new error, but no panic, this may be vim-go:
|
Same result with current gopls master |
Yeah, I do think that looks like a vim-go error. |
Handle some null arrays to avoid errors. Fixes fatih#2701
fatih/vim-go#2701 contains a report of a panic when finding references on a builtin. Avoid this by simply not returning any references. Change-Id: I195fcb4502634201888f0c65022c9d16169cc1f3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/218317 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> (cherry picked from commit 222e5d4) Reviewed-on: https://go-review.googlesource.com/c/tools/+/219123
I'm still hitting this on gopls I mitigated this error this by changing |
@davegallant FWIW we don't typically monitor closed issues. However, if you're still having problems, please file an issue if you're experiencing this on the latest vim-go master. |
What did you do? (required: The issue will be closed when not provided)
Set cursor on
iota
in the following withlet g:go_term_enabled = 1
What did you expect to happen?
Nothing.
What happened instead?
gopls
panicked:Configuration (MUST fill this out):
vim-go version:
v1.22 downloaded today
vimrc
you used to reproduce (use a minimal vimrc with other plugins disabled; do not link to a 2,000 line vimrc):vimrc
Vim version (first three lines from
:version
):NVIM v0.4.3
Build type: Release
LuaJIT 2.0.5
Go version (
go version
):go version go1.13.7 darwin/amd64
Go environment
go env
Output:gopls version
gopls version
Output:The text was updated successfully, but these errors were encountered: