fix: memory leak #4431
fix: memory leak #4431
Conversation
There was a problem hiding this comment.
Make only necessary modifications and avoid changing additional areas according to your own habits.
Channels will be garbage collected after they are no longer referenced, so there is no need to explicitly read all elements.
Try to provide reproducible steps and scenarios.
| @@ -54,7 +54,7 @@ type transporterImpl struct { | |||
|
|
|||
| func (impl *transporterImpl) Send(m msg.Message) error { | |||
There was a problem hiding this comment.
I intend to add a context parameter similar to the Do function to allow cancellation of sending.
One case is when the user exits manually, which can be canceled through this mechanism, and another case is for potential scenarios where a timeout might be set later.
There was a problem hiding this comment.
Adding context parameters would be a better solution.
In other cases, adding a timeout is indeed a viable solution, and I have considered using this pattern before
| @@ -54,7 +54,7 @@ type transporterImpl struct { | |||
|
|
|||
| func (impl *transporterImpl) Send(m msg.Message) error { | |||
There was a problem hiding this comment.
Additionally, a TrySend function can be added, which returns a specific error when sendCh is full, instead of blocking. This function is more suitable for certain specific scenarios.
There was a problem hiding this comment.
Yes，Adding TrySend is indeed a way to make it clearer. I didn't read the code thoroughly and may not fully understand the this function.
| @@ -66,6 +66,7 @@ func (d *Dispatcher) readLoop() { | |||
| m, err := ReadMsg(d.rw) | |||
| if err != nil { | |||
| close(d.doneCh) | |||
| close(d.sendCh) | |||
There was a problem hiding this comment.
sendCh does not need to be actively closed; it should be automatically reclaimed after all senders have exited.
As I commented in transport/message.go, I prefer to use a reasonable mechanism to ensure exit on the sender's side.
| @@ -97,7 +97,7 @@ func NewControl(ctx context.Context, sessionCtx *SessionContext) (*Control, erro | |||
| ctl.msgDispatcher = msg.NewDispatcher(sessionCtx.Conn) | |||
| } | |||
| ctl.registerMsgHandlers() | |||
| ctl.msgTransporter = transport.NewMessageTransporter(ctl.msgDispatcher.SendChannel()) | |||
| ctl.msgTransporter = transport.NewMessageTransporter(ctl.msgDispatcher.Send) | |||
WHY
在某些特殊情况下，会导致内存泄露
在发送比接收慢的情况下，容易出现sendCh满，会导致后续所有的 goroutine 泄露了