Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching models from example-models repo #919

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Nov 11, 2023

Description

fetch_example_model and fetch_example_list use outdated links so they no longer work. This PR fixes that. I made the organization and branch as variables so we can override them for debugging if needed. Also, this function expects .json +.h5 of weights, but we usually don't ask users to do this, so I added support for fetching models that are a single .h5 file.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality) -- sort of "new feature"

Tests

Do we want tests of this in pytest?

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar added the please test Trigger testing by creating local PR branch label Nov 14, 2023
@jmitrevs jmitrevs merged commit 6a92562 into fastmachinelearning:main Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants