Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise runtime error when a layer is named input #482

Merged
merged 1 commit into from
May 31, 2022
Merged

Raise runtime error when a layer is named input #482

merged 1 commit into from
May 31, 2022

Conversation

jmduarte
Copy link
Member

  • Raise runtime error when a layer is named input because it is a reserved layer name in HLSModel

Resolves #442 and many other similar situations

@jmduarte jmduarte added the bug label Dec 27, 2021
thesps
thesps reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@thesps thesps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest it might be better to put this in Layer.__init__

@jmduarte
Copy link
Member Author

@thesps moved as suggested

@jmduarte jmduarte requested a review from thesps May 11, 2022 14:00
@jmduarte jmduarte self-assigned this May 11, 2022
@vloncar vloncar merged commit f4ec30d into master May 31, 2022
@jmduarte jmduarte deleted the raise_exception_input branch May 31, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vloncar vloncar vloncar approved these changes

@thesps thesps Awaiting requested review from thesps

Assignees

@jmduarte jmduarte

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't synthesis Qkeras CNN model
3 participants
@jmduarte @thesps @vloncar