Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(index): merge lonely if #104

Closed
wants to merge 2 commits into from
Closed

refactor(index): merge lonely if #104

wants to merge 2 commits into from

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 22, 2023

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 22, 2023

can we have benchmarks please?

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 22, 2023 •
edited
Loading

Before:

image

After:

image

Bit slower. 😿

jsumners
jsumners reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think the original is easier to understand 🤷‍♂️

mcollina
mcollina approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 22, 2023

Closing as consistently slower in benchmarks.

@Fdawgs Fdawgs closed this Oct 22, 2023
@Fdawgs Fdawgs deleted the refactor/if branch October 22, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fdawgs @Uzlopak @mcollina @jsumners