Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions (zsh, fish): check for python3 #1310

Merged

Conversation

Davis-A
Copy link
Contributor

@Davis-A Davis-A commented Oct 2, 2024

Both the zsh and fish completions depend on python3. When the completitions kick in with those shells where no python3 is found it throws errors.

Check python3 is installed, otherwise return no completitions to avoid throwing errors

Both the zsh and fish completions depend on python3.
When the completitions kick in with those shells where no python3 is
found it throws errors.

Check python3 is installed, otherwise return no completitions to avoid
throwing errors
@Davis-A
Copy link
Contributor Author

Davis-A commented Oct 2, 2024

If you're using fish (or zsh with completions turned on) and the completions kick in and you lack python3, then it throws an error. eg

[17:43] adavis@carbon ~> fastfetch  fish: Unknown command: python3
/usr/share/fish/vendor_completions.d/fastfetch.fish (line 101):
' | python3 | source
    ^~~~~~^
from sourcing file /usr/share/fish/vendor_completions.d/fastfetch.fish
fastfetch                fastfetch

As far as i can tell no major (if any) distro packages list python3 as a dependency, so it'd be really nice to do something to avoid this. Whether my PR is the right answer or not is in the eye of the beholder :)

@CarterLi CarterLi merged commit 8a11aa0 into fastfetch-cli:dev Oct 2, 2024
@CarterLi
Copy link
Member

CarterLi commented Oct 2, 2024

May I ask what os are you using?

@Davis-A
Copy link
Contributor Author

Davis-A commented Oct 2, 2024

Thanks for merging.

May I ask what os are you using?

I noticed this on a new Arch install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants