Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more message details to sync health errors #2325

Merged

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 20, 2024

It's useful to have more information about the original message in these logs to understand if there are patterns in messages that result in certain types of submit errors.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR enhances logging in the syncHealthJob.ts file by adding more detailed message information for sync health errors.

Detailed summary

  • Added unixTimestampFromMessage method to extract Unix timestamp from message data
  • Updated processSumbitResults to include detailed message information in logs for successful and failed submissions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: a0e3d4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aditiharini aditiharini added the t-chore Miscellaneous improvements label Sep 20, 2024
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 5:35pm

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (1880070) to head (e469f86).
Report is 362 commits behind head on main.

Files with missing lines Patch % Lines
apps/hubble/src/network/sync/syncHealthJob.ts 20.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2325       +/-   ##
===========================================
- Coverage   74.05%   44.01%   -30.05%     
===========================================
  Files          99      146       +47     
  Lines        9425    25978    +16553     
  Branches     2097     9371     +7274     
===========================================
+ Hits         6980    11434     +4454     
- Misses       2327    12697    +10370     
- Partials      118     1847     +1729     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit 3b1d12f into farcasterxyz:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant