Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new metric for tracking count of successfully merged messages #2290

Merged

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 3, 2024

Why is this change needed?

We're currently using hubble.hub.merge_message.count for the message count metric and it looks skewed because some hubs have more messages submitted as bundles than others and each bundle only count as a single message rather than as the number of individual messages inside them. Create a new metric to track successfully merged messages (we already have a metric for errors).

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

The focus of this PR is to increment a statsd metric when a message submission is successful in the Hub class of the Hubble app.

Detailed summary

  • Increment statsd metric on successful message submission in submit_message method.
  • Added statsd metric incrementation in the mergeResult match block.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: b2ef13e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 10:04pm

@aditiharini aditiharini added t-bug A fix for a bug with the current system t-chore Miscellaneous improvements and removed t-bug A fix for a bug with the current system labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.34%. Comparing base (1880070) to head (b2ef13e).
Report is 336 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2290       +/-   ##
===========================================
- Coverage   74.05%   44.34%   -29.72%     
===========================================
  Files          99      146       +47     
  Lines        9425    25474    +16049     
  Branches     2097     9059     +6962     
===========================================
+ Hits         6980    11297     +4317     
- Misses       2327    12427    +10100     
- Partials      118     1750     +1632     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini marked this pull request as ready for review September 3, 2024 20:47
@aditiharini aditiharini changed the title feat: register one merge message per message in bundle feat: add a new metric for tracking count of successfully merged messages Sep 3, 2024
@aditiharini aditiharini merged commit a5b1870 into farcasterxyz:main Sep 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants