-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new metric for tracking count of successfully merged messages #2290
feat: add a new metric for tracking count of successfully merged messages #2290
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2290 +/- ##
===========================================
- Coverage 74.05% 44.34% -29.72%
===========================================
Files 99 146 +47
Lines 9425 25474 +16049
Branches 2097 9059 +6962
===========================================
+ Hits 6980 11297 +4317
- Misses 2327 12427 +10100
- Partials 118 1750 +1632 ☔ View full report in Codecov by Sentry. |
695416e
to
02cffb1
Compare
02cffb1
to
b2ef13e
Compare
Why is this change needed?
We're currently using hubble.hub.merge_message.count for the message count metric and it looks skewed because some hubs have more messages submitted as bundles than others and each bundle only count as a single message rather than as the number of individual messages inside them. Create a new metric to track successfully merged messages (we already have a metric for errors).
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
The focus of this PR is to increment a statsd metric when a message submission is successful in the
Hub
class of the Hubble app.Detailed summary
submit_message
method.mergeResult
match block.