feat: add more logging for on chain events #2247
Conversation
🦋 Changeset detectedLatest commit: a7ad5fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2247 +/- ##
===========================================
- Coverage 74.05% 45.31% -28.75%
===========================================
Files 99 144 +45
Lines 9425 23314 +13889
Branches 2097 8115 +6018
===========================================
+ Hits 6980 10564 +3584
- Misses 2327 11231 +8904
- Partials 118 1519 +1401 ☔ View full report in Codecov by Sentry. |
| @@ -479,6 +488,11 @@ export class L2EventsProvider<chain extends Chain = Chain, transport extends Tra | |||
| for (const event of logs) { | |||
| const { blockNumber, blockHash, transactionHash, transactionIndex, logIndex } = event; | |||
|
|
|||
| log.info( | |||
| { blockNumber, blockHash, transactionHash, transactionIndex, logIndex, eventName: event.eventName }, | |||
There was a problem hiding this comment.
I don't think you need all these tags? Just blockNumber and transactionHash (and maybe log index) should be sufficient?
|
Do we still need this? |
Why is this change needed?
With the current logging it's hard to determine if we dropped an on-chain event or never received it in the first place. This feature adds a log in the first place where our code is responsible for handling on-chain events to give us better insight into this moving forward.
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewPR-Codex overview
This PR enhances the logging for on-chain events in the
L2EventsProviderclass in the@farcaster/hubblepackage.Detailed summary
L2EventsProvider.