Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hubble/libp2p): fetch addresses once per peerid in getPeerAddresses [WIP] #2192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

varunsrin
Copy link
Member

@varunsrin varunsrin commented Jul 16, 2024

Why is this change needed?

We currently fetch the address book from the peer store once per connection to the peerId.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on improving the logic for managing known peer addresses in the getPeerAddresses method of the GossipNodeWorker class.

Detailed summary

  • Retrieve known addresses using peerStore.addressBook.get before iterating existing connections
  • Add new known addresses to the address book if not already present

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 4:02pm

Copy link

changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 688f673

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants