Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Hubble ports in .env #1394

Closed
wants to merge 0 commits into from
Closed

Configure Hubble ports in .env #1394

wants to merge 0 commits into from

Conversation

vrypan
Copy link
Contributor

@vrypan vrypan commented Sep 19, 2023

Motivation

I'm running Hubble using non-standard ports (not 2282, 2283). To do so, I had to change docker-compose.yml, but the yaml file gets overwritten every time I upgrade to a new version.

Change Summary

docker-compose.yml uses two env variables, GOSSIP_PORT and RPC_PORT, to set the ports. If not found it defaults to the standard ones.


PR-Codex overview

This PR focuses on making the gossip and RPC ports configurable through environment variables.

Detailed summary

  • Updated docker-compose.yml to use environment variables for gossip and RPC ports.
  • Added comments indicating how to set the ports in the .env file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: f743a43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 11:31am

@adityapk00
Copy link
Contributor

This PR looks good, but the tests are not passing - You need to rebase on main (or merge main into your branch) to make the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants