Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hub operator's FID #1352

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Conversation

adityapk00
Copy link
Contributor

@adityapk00 adityapk00 commented Sep 7, 2023

Motivation

Allow Hub operators to set an FID to identify the operator of a Hub. Optional

Change Summary

  • Add --hub-operator-fid and validations
  • Report it as a part of sync status

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Focus of this PR:

This PR focuses on adding the ability for Hub operators to set an FID.

Detailed summary:

  • Added peerId field to HubInfoResponse protobuf message.
  • Added hubOperatorFid field to HubInfoResponse protobuf message.
  • Added hubOperatorFid field to HubOptions interface.
  • Added hubOperatorFid field to Hub class.
  • Modified CLI to accept --hub-operator-fid option.
  • Added startup check for Hub Operator FID.
  • Added logic to fetch and display username for Hub Operator FID during startup.
  • Updated documentation to include instructions for setting Hub Operator FID.

The following files were skipped due to too many changes: packages/hub-nodejs/src/generated/request_response.ts, packages/core/src/protobufs/generated/request_response.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@adityapk00 adityapk00 added the t-feat Add a new feature or protocol improvement label Sep 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: c5dded6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/core Patch
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:57am

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage is 50.00% of modified lines.

Files Changed Coverage
apps/hubble/src/hubble.ts 0.00%
apps/hubble/src/network/sync/syncEngine.ts 0.00%
apps/hubble/src/rpc/server.ts 66.66%
apps/hubble/src/storage/engine/index.ts 100.00%

📢 Thoughts on this report? Let us know!.

@adityapk00
Copy link
Contributor Author

@varunsrin - Can you review the docs part of this PR to add the Hub operator? (In apps/hubble/www/docs/intro/install.md)

@adityapk00 adityapk00 merged commit bc416db into farcasterxyz:main Sep 7, 2023
8 of 9 checks passed
@adityapk00 adityapk00 deleted the opfid branch September 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant