Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move call to onResponse #189

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: move call to onResponse #189

merged 1 commit into from
Aug 14, 2024

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Aug 14, 2024 •
edited
Loading

Motivation

#177 had the right idea, but we need to call onResponse on every response, not just success.

Change Summary

Move onResponse outside success code check.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • PR title adheres to the conventional commits standard
  • PR has a changeset
  • PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
  • PR includes documentation if necessary
  • All commits have been signed

@horsefacts horsefacts added the bug label Aug 14, 2024
@horsefacts horsefacts marked this pull request as ready for review August 14, 2024 20:31
@horsefacts horsefacts merged commit b4178d2 into main Aug 14, 2024
3 checks passed
@horsefacts horsefacts deleted the horsefacts/fix-on-response branch August 14, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@horsefacts