Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): add authorized_server_binary list #41

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix(rules): add authorized_server_binary list #41

merged 1 commit into from
Mar 29, 2023

Conversation

ch3n9w
Copy link
Contributor

@ch3n9w ch3n9w commented Mar 29, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: the rule Outbound or Inbound Traffic not to Authorized Server Process and Port depends authorized_server_binary list, which is missing so I add it.

Signed-off-by: ch3n <40637063+ch3n9w@users.noreply.github.com>
@poiana
Copy link

poiana commented Mar 29, 2023

Welcome @ch3n9w! It looks like this is your first PR to falcosecurity/rules 🎉

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! And congrats for your first contribution here! 🙏

Link to original discussion: falcosecurity/falco@2c2d126#commitcomment-106025762

/approve

@poiana
Copy link

poiana commented Mar 29, 2023

LGTM label has been added.

Git tree hash: 3ace855815fbbb94998ceb6402e01167b4215bc8

@poiana
Copy link

poiana commented Mar 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ch3n9w, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e0646a0 into falcosecurity:main Mar 29, 2023
@jasondellaluce jasondellaluce added this to the falco-rules-1.0.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants