Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge the two docker_binaries into a single one, the first was overrided #27

Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Feb 13, 2023

Signed-off-by: Thomas Labarussias issif+github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

The falco_rules.yaml contained 2 lists for docker_binaries, without an append, the first was totally override. I merged them into a single one.

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Feb 13, 2023

@Issif: The label(s) kind/bug, area/rules cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Thomas Labarussias issif+github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

The falco_rules.yaml contained 2 lists for docker_binaries, without an append, the first was totally override. I merged them into a single one.

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Thomas Labarussias <issif+github@gadz.org>
@Issif Issif force-pushed the fix-duplicated-list-docker-binaries branch from bde433e to 809b911 Compare February 13, 2023 14:32
@poiana
Copy link

poiana commented Feb 14, 2023

LGTM label has been added.

Git tree hash: b8c4733d083d72660a4be7aad9a78551aff2c333

@leogr
Copy link
Member

leogr commented Mar 19, 2023

This may fix some regressions introduced by 9d36827

@darryk10 @loresuso @LucaGuerra can we double check pls?

@leogr leogr added this to the falco-rules-0.2 milestone Mar 19, 2023
@poiana
Copy link

poiana commented Mar 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3f52480 into falcosecurity:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants