Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid engine_version_semver key in latest rules package #225

Closed
2 tasks done
loresuso opened this issue Feb 9, 2024 · 5 comments · Fixed by #226
Closed
2 tasks done

Invalid engine_version_semver key in latest rules package #225

loresuso opened this issue Feb 9, 2024 · 5 comments · Fixed by #226
Assignees
Labels
kind/bug Something isn't working

Comments

@loresuso
Copy link
Member

loresuso commented Feb 9, 2024

Describe the bug

The newly released package for the Falco rules contains a semver version of 0.0.0

falcoctl artifact config falco-rules | jq 
{
  "name": "falco-rules",
  "version": "3.0.0",
  "requirements": [
    {
      "name": "engine_version_semver",
      "version": "0.0.0"
    }
  ]
}

Together with @leogr we spotted the bug. I'll open a PR soon to fix it.

How to reproduce it

Expected behaviour

Screenshots

Environment

  • Falco version:
  • System info:
  • Cloud provider or hardware configuration:
  • OS:
  • Kernel:
  • Installation method:

Additional context

Tasks

  1. approved dco-signoff: yes lgtm size/M
    leogr
@leogr
Copy link
Member

leogr commented Feb 9, 2024

We will need to re-release (or repuplish) 3.0.0 artifacts with the correct configuration.

/assign
/assign @LucaGuerra

@leogr
Copy link
Member

leogr commented Feb 9, 2024

/reopen since we still need to republish artifacts

@leogr
Copy link
Member

leogr commented Feb 13, 2024

/reopen

@poiana poiana reopened this Feb 13, 2024
@poiana
Copy link

poiana commented Feb 13, 2024

@leogr: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LucaGuerra
Copy link
Contributor

released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants