update: sync done by the config itself

[cappellinsamuele]

Refactor of the main loop to improve tests.

[jasondellaluce]

Suggested change

	func (g *GithubConfig) Loop(client Client, provider SecretsProvider) error {
	func (g *GithubConfig) Loop(client *Client, provider SecretsProvider) error {

I know it can be confusing, but Client would need to be a pointer here, whereas SecretsProvider does not. The reason is that SecretsProvider is an interface type, which means that under the hood it is already "pointing to something". Since Config is a struct instead, passing it not as a pointer would cause the whole data struct to be copied. Not a big deal but also not ideal.

[FedeDP]

I think Loop should take ActionsVarsService and ActionsSecretsService as input in place of Client, so that we can use it in tests mocking both interfaces.

[FedeDP]

I'd also refactor out the

conf := poiana.GithubConfig{}
	err := conf.Decode(strings.NewReader(sampleYAML))
	if err != nil {
		fail(err.Error())
	}
	provider, _ := poiana.NewMockSecretsProvider(map[string]string{
		"TEST_SECRET_KEY2": "ciaociaociao2",
		"TEST_SECRET_KEY":  "ciaociaociao",
})

To a couple of ctors like

config.FromFile(yamlFile)
config.FromData(yamlData)

WDYT?
We can do it in a later step though ;)

[FedeDP]

/approve