Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add license headers and spdx id #16

Merged
merged 1 commit into from
Oct 11, 2023
Merged

docs: add license headers and spdx id #16

merged 1 commit into from
Oct 11, 2023

Conversation

leogr
Copy link
Member

@leogr leogr commented Oct 11, 2023

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area commands
/area pkg
/area tests

What this PR does / why we need it:

See falcosecurity/evolution#318

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@leogr
docs: add license headers and spdx id
3aab63b 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana
Copy link

poiana commented Oct 11, 2023

@leogr: The label(s) kind/documentation, area/commands, area/pkg, area/tests cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area commands
/area pkg
/area tests

What this PR does / why we need it:

See falcosecurity/evolution#318

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/L label Oct 11, 2023
@leogr leogr mentioned this pull request Oct 11, 2023
Closed
FedeDP
FedeDP approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 11, 2023
@poiana
Copy link

poiana commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member Author

leogr commented Oct 11, 2023

/area commands
/area pkg
/area tests

@leogr
Copy link
Member Author

leogr commented Oct 11, 2023

/kind documentation

@poiana poiana added the kind/documentation Improvements or additions to documentation label Oct 11, 2023
@poiana poiana merged commit e3568c2 into main Oct 11, 2023
3 checks passed
@poiana poiana deleted the docs/spdx-id branch October 11, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@FedeDP FedeDP

Labels
approved area/commands area/pkg area/tests dco-signoff: yes kind/documentation Improvements or additions to documentation lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogr @poiana @FedeDP