Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure all uploads avoid clashes and respect the extension #115

Merged
merged 7 commits into from
Jun 14, 2024
Merged

fix: ensure all uploads avoid clashes and respect the extension #115

merged 7 commits into from
Jun 14, 2024

Conversation

chamini2
Copy link
Member

@chamini2 chamini2 commented Mar 15, 2024 •
edited
Loading

closes FEA-2115

@linear Linear
Copy link

linear bot commented Mar 15, 2024

FEA-2096 Use set extension for download links of GCS

@chamini2 chamini2 force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch 4 times, most recently from c0eb957 to 8b4c936 Compare March 15, 2024 21:50
@chamini2 chamini2 changed the title fix: use path in url of File uploads fix: ensure all uploads avoid clases and respect the extension Mar 15, 2024
@chamini2 chamini2 force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch from 8b4c936 to 8ad665a Compare March 15, 2024 22:12
@chamini2 chamini2 changed the title fix: ensure all uploads avoid clases and respect the extension fix: ensure all uploads avoid clashes and respect the extension Mar 18, 2024
@chamini2 chamini2 force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch from 1ec0f94 to c2ab869 Compare March 19, 2024 05:23
mederka
mederka reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@mederka mederka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a file not committed by mistake?

@chamini2 chamini2 force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch from c2ab869 to ed07ce1 Compare March 19, 2024 16:05
@chamini2
Copy link
Member Author

Was a file not committed by mistake?

no, doing TDD and the tests now sucessfully fail 😄

@chamini2 chamini2 force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch from ed07ce1 to 19e2fae Compare May 16, 2024 20:02
@linear Linear
Copy link

linear bot commented May 16, 2024

FEA-2115 make files more random not to override R2

@efiop
Copy link
Contributor

efiop commented May 16, 2024

for the record: taking over...

@efiop efiop self-assigned this May 16, 2024
@efiop efiop force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch from 1cea177 to 47ef1b8 Compare June 12, 2024 00:07
kakkoyun
kakkoyun approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAIT

@efiop
Copy link
Contributor

efiop commented Jun 12, 2024

Depends on https://github.com/fal-ai/fal-cdn/pull/2

@efiop efiop force-pushed the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch from cd3d2a7 to c4cfc42 Compare June 14, 2024 19:31
@efiop efiop merged commit 48034cb into main Jun 14, 2024
5 checks passed
@efiop efiop deleted the matteo/fea-2096-use-set-extension-for-download-links-of-gcs branch June 14, 2024 19:45
@efiop efiop mentioned this pull request Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop left review comments

@mederka mederka mederka left review comments

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

@efiop efiop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chamini2 @efiop @kakkoyun @mederka