Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dog breed names for en-US locale #2972

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mononoken
Copy link
Contributor

Motivation / Background

I started this PR from noticing data generated from Faker::Creature::Dog.breed had African as a dog breed. This is not a valid dog breed from searching online. There is a breed called Africanis, so I have updated this entry to that.

While updating this value, I noticed some other names that could be cleaned up such as Stbernard being updated to Saint Bernard. I also noted that the docs state to use dash syntax, so I formatted the file first so that it would be easy to follow the name changes.

Additional information

I used https://en.wikipedia.org/wiki/List_of_dog_breeds as a reference. I did not change every inconsistency compared to these wiki names. For example, "Irish Spaniel" is not an entry on the wiki. I mostly tried to target errors and typos.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

@mononoken mononoken changed the title Update locale en dog Update locale en dog breed names Jun 25, 2024
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

@thdaraujo thdaraujo merged commit 264cc0c into faker-ruby:main Jul 9, 2024
8 checks passed
@thdaraujo thdaraujo changed the title Update locale en dog breed names Update dog breed names for en-US locale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants