Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjectives to Korean locale file #2930

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

connie-feng
Copy link
Contributor

@connie-feng connie-feng commented Apr 6, 2024

Motivation / Background

This Pull Request has been created because I added Korean translations for positive and negative adjectives. I also refactored the entire ko.yml file to use dash syntax, per the README.

Additional information

This change is based on translating the existing English adjectives file. I have a TOPIK 6 certificate, which is the highest level certificate for Korean language proficiency. I have also cross-referenced the translations with Naver Dictionary and Google Translate.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@psibi psibi merged commit 6db1e8f into faker-ruby:main Apr 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants