Add the Ukrainian country calling code #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
ukrainian-country-code
branch
from
fb5d56d
to
8a46661
Compare
thdaraujo
requested changes
May 7, 2023
lib/locales/uk.yml
Outdated
| @@ -55,6 +55,8 @@ uk: | |||
| name_with_middle: | |||
| - "#{first_name} #{last_name} #{last_name}" | |||
|
|
|||
| country_code: ['38'] | |||
There was a problem hiding this comment.
let's add the correct code instead:
Suggested change
| country_code: ['38'] | |
| country_code: ['380'] |
kyrylo
force-pushed
the
ukrainian-country-code
branch
from
8a46661
to
22b7a71
Compare
|
Thanks, added! PTAL |
thdaraujo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🇺🇦
I should mention that the correct dialing code is
380. However, when I callFaker::PhoneNumber.cell_phone_in_e164, it returns a number akin to+3800636232872. Note the extra zero. It should be+380636232872instead.Compare:
+3800636232872+380636232872