Test the Vehicle VIN validator with known good and bad values, fixes … #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only broken test here is fixed in #2638 |
This was referenced Jan 3, 2023
…efactor deterministic tests
|
I removed the standalone (duplicate) vin regex test, which is checked inside the I think this PR is good to go. |
stefannibrasil
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Nice, thanks for improving the password tests, too. thank you @alextaujenis 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An issue could occur where both the Vehicle VIN generator and validator are refactored in this library (for instance, changing the modulus operator from 11 to 10). This would change both the checksum generator and validator, allowing the test suite to pass, but fundamentally changing (and corrupting) the VIN checksum algorithm.
To protect against this, as well as giving confidence to anyone refactoring the Vehicle VIN generator or validator, several known good and bad VIN checks have been added as tests.