Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document IBAN digits validity generator #2625

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

stefannibrasil
Copy link
Contributor

Although we would like to support all cases and have higher accuracy, it would require too much effort to accommodate.

Faker generates valid IBAN check digits but does not support national check digits used within the BBAN.

If this behavior is critical for an app, it's recommend to generate its own IBAN digits validity check.

Close #2588

Although we would like to support all cases and have higher accuracy, it would require too much effort to accommodate.

Faker generates valid IBAN check digits but does not support national check digits used within the BBAN.

If this behavior is critical for an app, it's recommend to generate its own IBAN digits validity check.

See [faker-ruby#2588](faker-ruby#2588) for more details.
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this!

@thdaraujo thdaraujo merged commit 222b8e7 into faker-ruby:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

French iban has invalid checksum
2 participants