Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed css hex color prefix (see #527) #625

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

ennerf
Copy link
Collaborator

@ennerf ennerf commented Sep 28, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pr-explainer-bot
Copy link

Pull Request Report

Hey there! I've analyzed the changes in the pull request and here's a report for you:

Changes

  1. In LabelledMarkerRendererTests.java:

    • Line 150: Changed .setLineColor("0xEE00EE") to .setLineColor("#EE00EE")
    • Line 151: Changed .setMarkerColor("0xEE00EE") to .setMarkerColor("#EE00EE")
  2. In DataSetStyleParserTest.java:

    • Line 39: Changed assertEquals("-fx-fill: 0xffff00ff;", style) to assertEquals("-fx-fill: #ffff00ff;", style)
    • Line 73: Changed .setStroke("0xEE00EE") to .setStroke("#EE00EE")
    • Line 74: Changed .setFill("0xEE00EE") to .setFill("#EE00EE")
  3. In StyleBuilder.java:

    • Line 68: Changed properties.put(key, String.format("0x%02x%02x%02x%02x", r & 0xFF, g & 0xFF, b & 0xFF, o & 0xFF)) to properties.put(key, String.format("#%02x%02x%02x%02x", r & 0xFF, g & 0xFF, b & 0xFF, o & 0xFF))
  4. In LabelledMarkerSample.java:

    • Line 59: Changed .setStroke("0xEE00EE") to .setStroke("#EE00EE")
    • Line 60: Changed .setFill("0xEE00EE") to .setFill("#EE00EE")

Suggestions

No suggestions for improvement were found.

Bugs

No potential bugs were found.

Improvements

No improvements were found.

Rating

I would rate the code as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 10/10

That's it for the report! Let me know if you need anything else. Have a great day! 😄

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9508d3c) 48.09% compared to head (15f88c3) 48.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #625      +/-   ##
============================================
+ Coverage     48.09%   48.17%   +0.08%     
- Complexity     6213     6239      +26     
============================================
  Files           374      374              
  Lines         38299    38390      +91     
  Branches       6110     6134      +24     
============================================
+ Hits          18419    18494      +75     
- Misses        18721    18734      +13     
- Partials       1159     1162       +3     
Files Coverage Δ
...n/java/io/fair_acc/dataset/utils/StyleBuilder.java 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wirew0rm wirew0rm merged commit 380940a into main Sep 28, 2023
11 of 12 checks passed
@wirew0rm wirew0rm deleted the ennerf/fix-css-prefix branch September 28, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants