-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sinusoid tone generation #127
Conversation
Thanks for the PR, I just have a couple comments/suggestions. It looks like a linter hasn't been run on the code; there are no indentions. Please run this through the go linter and update the PR. |
examples/tone-player/main.go
Outdated
"strconv" | ||
) | ||
func main() { | ||
f, _ := strconv.Atoi(os.Args[1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a usage message if the argument isn't provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if it's provided and it's not an integer.
Thanks for the changes, looks good! |
Fix flac.Decode handling of io.EOF
closes #126