Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPUnit 11 compatibility #230

Merged
merged 13 commits into from
Feb 6, 2024
Merged

Fix PHPUnit 11 compatibility #230

merged 13 commits into from
Feb 6, 2024

Conversation

Jean85
Copy link
Member

@Jean85 Jean85 commented Feb 4, 2024

This PR started from #229 because we need additional permissions to have a secret PAT to download forks with Composer.

This fix is needed because #228 didn't actually execute with PHPUnit 11 since there were conflicting requirements, Prophecy in particular.

@Jean85
Copy link
Member Author

Jean85 commented Feb 4, 2024

Ok it seems that if I run the PR, the auth for the forks work. Still, no PHPUnit 11.

I'll try to add an additional CI job to forcibly test for it.

@Jean85 Jean85 added the bug label Feb 4, 2024
@Jean85 Jean85 added this to the 2.3 milestone Feb 4, 2024
@Jean85 Jean85 linked an issue Feb 4, 2024 that may be closed by this pull request
@Jean85 Jean85 changed the title Allow phpunit 11 bis Fix PHPUnit 11 compatibility Feb 4, 2024
@Jean85 Jean85 self-assigned this Feb 4, 2024
This was referenced Feb 4, 2024
@Jean85 Jean85 force-pushed the allow-phpunit-11-bis branch 2 times, most recently from 6e70707 to e0be898 Compare February 4, 2024 23:09
@Jean85 Jean85 force-pushed the allow-phpunit-11-bis branch 2 times, most recently from 34452d5 to eda6ca0 Compare February 6, 2024 08:41
@Jean85 Jean85 marked this pull request as ready for review February 6, 2024 09:02
@Jean85 Jean85 merged commit 73dfb78 into 2.x Feb 6, 2024
11 checks passed
@Jean85 Jean85 deleted the allow-phpunit-11-bis branch February 6, 2024 09:07
@Jean85 Jean85 mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PHPUnit 11
2 participants