Re-enable alternative plans in join fuzzer #9898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57696398 |
✅ Deploy Preview for meta-velox canceled.
|
Summary: Alternative join plans (including sort + merge join) were accidentaly disabled in a recent refactor (facebookincubator#9045). Re-enabling them in this PR. Differential Revision: D57696398
pedroerp
force-pushed
the
export-D57696398
branch
from
e00aafe
to
5c9704f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57696398 |
xiaoxmeng
approved these changes
May 22, 2024
|
This pull request has been merged in 96c51ae. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9898 Alternative join plans (including sort + merge join) were accidentaly disabled in a recent refactor (facebookincubator#9045). Re-enabling them in this PR. Reviewed By: mbasmanova Differential Revision: D57696398 fbshipit-source-id: d0264a1fa214f0e1b46ab03b54fa76fd5fb59173
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9898 Alternative join plans (including sort + merge join) were accidentaly disabled in a recent refactor (facebookincubator#9045). Re-enabling them in this PR. Reviewed By: mbasmanova Differential Revision: D57696398 fbshipit-source-id: d0264a1fa214f0e1b46ab03b54fa76fd5fb59173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Alternative join plans (including sort + merge join) were accidentaly
disabled in a recent refactor
(#9045).
Re-enabling them in this PR.
Differential Revision: D57696398