Back out "Refactor greatest and least Presto functions using simple function API" #9493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56160832 |
✅ Deploy Preview for meta-velox canceled.
|
bikramSingh91
approved these changes
Apr 15, 2024
s4ayub
added a commit
to s4ayub/velox
that referenced
this pull request
Apr 16, 2024
…unction API" (facebookincubator#9493) Summary: Temporarily reverting as the switch to using a simple function implementation for 'greatest' and 'least' functions are causing issues registering the UDF for some internal use-cases. Original commit changeset: c389bad91197 Original Phabricator Diff: D55793910n Reviewed By: wqfish, bikramSingh91 Differential Revision: D56160832
s4ayub
force-pushed
the
export-D56160832
branch
from
e7a3d45
to
d0048f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56160832 |
…unction API" (facebookincubator#9493) Summary: Temporarily reverting as the switch to using a simple function implementation for 'greatest' and 'least' functions are causing issues registering the UDF for some internal use-cases. Original commit changeset: c389bad91197 Original Phabricator Diff: D55793910n Reviewed By: wqfish, bikramSingh91 Differential Revision: D56160832
s4ayub
force-pushed
the
export-D56160832
branch
from
d0048f6
to
6f4d98b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56160832 |
|
This pull request has been merged in fd5643a. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…unction API" (facebookincubator#9493) Summary: Temporarily reverting as the switch to using a simple function implementation for 'greatest' and 'least' functions are causing issues registering the UDF for some internal use-cases. Pull Request resolved: facebookincubator#9493 Original commit changeset: c389bad91197 Original Phabricator Diff: D55793910n Reviewed By: wqfish, bikramSingh91 Differential Revision: D56160832 fbshipit-source-id: f7550b819f8b8f276b88cb33c52de05807a4f2d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Temporarily reverting as the switch to using a simple function implementation for 'greatest' and 'least' functions are causing issues registering the UDF for some internal use-cases.
Original commit changeset: c389bad91197
Original Phabricator Diff: D55793910n
Reviewed By: wqfish
Differential Revision: D56160832