Pass input types to simple function's 'initialize' method #9124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
5e53545
to
f62581f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
f62581f
to
9a6179c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
9a6179c
to
9c7f57b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
9c7f57b
to
b24dc73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
b24dc73
to
e3f13e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
xiaoxmeng
approved these changes
Mar 19, 2024
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 19, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
e3f13e3
to
0111726
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 19, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
0111726
to
cd6ea36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 19, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
cd6ea36
to
ade023c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 19, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
ade023c
to
22c11e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 19, 2024
…cubator#9124) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189
mbasmanova
force-pushed
the
export-D55012189
branch
from
22c11e2
to
da42605
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
mbasmanova
force-pushed
the
export-D55012189
branch
from
da42605
to
5912e1b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55012189 |
|
This pull request has been merged in ca0f4a9. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 20, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 20, 2024
…cubator#9124) Summary: Pull Request resolved: facebookincubator#9124 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55012189 fbshipit-source-id: 95d5d05054730a41788a4fac51fe78f77c7bfac2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information via 'initialize' method.
See #9096 for the end-to-end workflow.
Differential Revision: D55012189