Pass input types to SimpleFunctionAdapterFactory::createVectorFunction #9120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55011267
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55011267 |
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
facebookincubator#9120) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55011267
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
facebookincubator#9120) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55011267
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
facebookincubator#9120) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55011267
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
facebookincubator#9120) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55011267
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Mar 18, 2024
facebookincubator#9120) Summary: This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Differential Revision: D55011267
xiaoxmeng
approved these changes
Mar 18, 2024
| @@ -434,12 +434,12 @@ ExprPtr compileRewrittenExpression( | |||
| simpleFunctionEntry->type(), | |||
| resultType, | |||
| folly::join(", ", inputTypes)); | |||
| auto func_2 = simpleFunctionEntry->createFunction()->createVectorFunction( | |||
| getConstantInputs(compiledInputs), config); | |||
| auto func = simpleFunctionEntry->createFunction()->createVectorFunction( | |||
|
This pull request has been merged in 5cfb8eb. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
facebookincubator#9120) Summary: Pull Request resolved: facebookincubator#9120 This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method. See facebookincubator#9096 for the end-to-end workflow. Reviewed By: xiaoxmeng Differential Revision: D55011267 fbshipit-source-id: 323e39aec04e0fd6d0db4b4be4bfdf4bd9544dd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change is part of enabling simple functions to process inputs of decimal type. Such processing requires access to decimal type parameters (precision and scale). This change provides full type information to the function constructor. A follow-up change will pass this to simple function's 'initialize' method.
See #9096 for the end-to-end workflow.
Differential Revision: D55011267