Implement Presto aggregate function map_union #1827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 17, 2022
Summary: Pull Request resolved: facebookincubator#1827 Added a new velox aggregate `map_union` that: - Takes as input a `map` - Stores the results in an accumulator that is in the form of `key` and `value` lists - Intermediate and Final results are of type `map` - Clubbed the logic that is common for map_agg and map_union into a new class named `MapAggregateBase` - Unit Tests that check: - `Partial/Final aggregate` results, `Single aggregate` results and `Global aggregate` results - Input that contains `NULL` in the `key`/`value`, duplicate `keys` and no data Differential Revision: D37088301 fbshipit-source-id: 8a70e73f306d978d69f16bedcd1077712472e9ff
benitakbritto
force-pushed
the
export-D37088301
branch
from
e902396
to
62ea7f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 21, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: b95e7b55bac2dea9797c933314c5b3f84d4f1497
benitakbritto
force-pushed
the
export-D37088301
branch
from
62ea7f4
to
bc6e44f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 22, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 1c1d429eb45be272fbba1e436c22cf5814c1888c
benitakbritto
force-pushed
the
export-D37088301
branch
from
bc6e44f
to
d66ee75
Compare
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 22, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 77a49a0fb7572c9d06d2dff6baf3a441ddc86e9f
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 22, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 168683a4ee74d6cdb663eb54f1ccdbe2a667c6ae
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 23, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Reviewed By: kagamiori Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: c5148e38c5c61c0b9b60473a5e4ba28cfe083677
benitakbritto
force-pushed
the
export-D37088301
branch
from
d66ee75
to
815023f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 23, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: b4ab9798532f575179753a04cec0fdc22a53d910
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 24, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: f0edbed62c6b065d8972d867d3e90423ede26565
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 24, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Reviewed By: kagamiori Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 466bf5b1f894b970db07106a7c531032e35b590d
benitakbritto
force-pushed
the
export-D37088301
branch
from
815023f
to
410dae3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Reviewed By: kagamiori Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 209ee7b1ad2e41608226215f3bcb788d687af8e4
benitakbritto
force-pushed
the
export-D37088301
branch
from
410dae3
to
2002953
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37088301 |
benitakbritto
pushed a commit
to benitakbritto/velox
that referenced
this pull request
Jun 24, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 2a863a850a9244b76a6f1611e7f27a3064612344
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: facebookincubator#1827 Test Plan: ## Unit Test ``` [~/fbsource/fbcode]$ buck test velox/functions/prestosql/aggregates/tests:test ``` ## End-to-end Test ``` [~/fbsource/fbcode/presto_cpp/public_tld/java/presto-native-tests]$ JAVA_HOME=/usr/local/fb-jdk-8 mvn -Dmaven.compiler.fork=true -Dmaven.compiler.executable=/usr/local/fb-jdk-8/bin/javac -Djava.net.preferIPv6Addresses=true -DPRESTO_SERVER=$HOME/fbsource/fbcode/buck-out/gen/presto_cpp/main/presto_server -DDATA_DIR=/tmp -Duser.timezone=America/Bahia_Banderas -Dtest=TestHiveAggregationQueries test ``` Reviewed By: kagamiori Differential Revision: D37088301 Pulled By: benitakbritto fbshipit-source-id: 5687b1962299596c91467035f1e63d559e01bd46
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
…g hash agg (facebookincubator#1827) Fix error 'attribute binding failed.' when executing hash agg Close facebookincubator#1620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a new velox aggregate
map_unionthat:mapkeyandvaluelistsmapMapAggregateBasePartial/Final aggregateresults,Single aggregateresults andGlobal aggregateresultsNULLin thekey/value, duplicatekeysand no dataDifferential Revision: D37088301