Extract common utils from ColumnReader and create DwrfColumnReader
#1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
liushengxuan
force-pushed
the
shengxuan/interface_refactor
branch
2 times, most recently
from
074e897
to
86347e2
Compare
liushengxuan
force-pushed
the
shengxuan/interface_refactor
branch
from
86347e2
to
dc0cb73
Compare
liushengxuan
changed the title
ColumnReaderColumnReader and create DwrfColumnReader
liushengxuan
force-pushed
the
shengxuan/interface_refactor
branch
from
f6d6573
to
eef436c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions! |
marin-ma
added a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Add shuffle benchmark to velox shuffle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the first part of issue #1620.
Previously,
ColumnReaderand the derivedXXXColumnReaderwere Dwrf specific. However, some utils can also be applied to Parquet andColumnReadershould only keep the common features. So this PR decouples theDwrfColumnReaderfromColumnReaderand adjusted the other class structures accordiingly.ColumnReaderis moved to dwio::common::reader as the common util for both Dwrf and ParquetColumnReaderis replaced byDwrfColumnReader, which still remains at the same directory and inheritsColumnReader.XXXColumnReaderare renamed toXXXDwrfColumnReaderand inheritingDwrfColumnReader.