Pass EvalCtx and result VectorPtr by Reference #1612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
oerling
force-pushed
the
expr-ci-pr
branch
3 times, most recently
from
8ce1895
to
bef1e52
Compare
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Passes non-optional non-const parameters by reference. This avoids nullability specifiers required by Mac Circle CI builds. Adds nullability declarations to pointers tat need them. The scope of tis is expression/. The function base class signatures are not changed.
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 21, 2022
Summary: Passes non-optional non-const parameters by reference. This avoids nullability specifiers required by Mac Circle CI builds. Adds nullability declarations to pointers that need them. The scope of tis is expressions. The function base class signatures are not changed. Pull Request resolved: facebookincubator#1612 Reviewed By: mbasmanova Differential Revision: D36378417 Pulled By: oerling fbshipit-source-id: 2cd39123977fcff9c986992c3896d3a27c43a22f
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
Summary: Passes non-optional non-const parameters by reference. This avoids nullability specifiers required by Mac Circle CI builds. Adds nullability declarations to pointers that need them. The scope of tis is expressions. The function base class signatures are not changed. Pull Request resolved: facebookincubator#1612 Reviewed By: mbasmanova Differential Revision: D36378417 Pulled By: oerling fbshipit-source-id: 2cd39123977fcff9c986992c3896d3a27c43a22f
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
…#1618) What changes were proposed in this pull request? add format check for ch backend (Fixes: facebookincubator#1612) How was this patch tested? unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes non-optional non-const parameters by reference. This avoids
nullability specifiers required by Mac Circle CI builds. Adds
nullability declarations to pointers that need them.
The scope of tis is expressions. The function base class signatures
are not changed.