Fix timestamp and interval arithmetic bug #11017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62811693 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D62811693 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: facebookincubator#11017 For timestamps plus or minus intervals, the arithmetic needs to be done at the local timezone (not UTC) to account for intervals than span a daylight savings time boundary. This is already handled for timestamp with timezone types, and not needed for IntervalDayTime. Reviewed By: spershin Differential Revision: D62811693
pedroerp
force-pushed
the
export-D62811693
branch
from
c929b96
to
87e80da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62811693 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: facebookincubator#11017 For timestamps plus or minus intervals, the arithmetic needs to be done at the local timezone (not UTC) to account for intervals than span a daylight savings time boundary. This is already handled for timestamp with timezone types, and not needed for IntervalDayTime. Reviewed By: spershin Differential Revision: D62811693
pedroerp
force-pushed
the
export-D62811693
branch
from
87e80da
to
4184841
Compare
spershin
approved these changes
Sep 17, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62811693 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: facebookincubator#11017 For timestamps plus or minus intervals, the arithmetic needs to be done at the local timezone (not UTC) to account for intervals than span a daylight savings time boundary. This is already handled for timestamp with timezone types, and not needed for IntervalDayTime. Reviewed By: spershin Differential Revision: D62811693
pedroerp
force-pushed
the
export-D62811693
branch
from
4184841
to
62bf3c2
Compare
Summary: Pull Request resolved: facebookincubator#11017 For timestamps plus or minus intervals, the arithmetic needs to be done at the local timezone (not UTC) to account for intervals than span a daylight savings time boundary. This is already handled for timestamp with timezone types, and not needed for IntervalDayTime. Reviewed By: spershin Differential Revision: D62811693
|
This pull request was exported from Phabricator. Differential Revision: D62811693 |
pedroerp
force-pushed
the
export-D62811693
branch
from
62bf3c2
to
a1d2b81
Compare
|
This pull request has been merged in d8b60db. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For timestamps plus or minus intervals, the arithmetic needs to be
done at the local timezone (not UTC) to account for intervals than span a
daylight savings time boundary. This is already handled for timestamp with
timezone types, and not needed for IntervalDayTime.
Reviewed By: spershin
Differential Revision: D62811693