Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FunctionSignature returnType optional and refactor Spark function round decimal #10487

Closed
wants to merge 3 commits into from
Closed

Set FunctionSignature returnType optional and refactor Spark function round decimal #10487

wants to merge 3 commits into from

Conversation

jinchengchenghh
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a04ba23
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66978305bd477d000854311a

@jinchengchenghh jinchengchenghh mentioned this pull request Jul 17, 2024
Closed
mbasmanova
mbasmanova requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem you are trying to solve? Would you provide some detailed examples?

@jinchengchenghh
Copy link
Contributor Author

The SpecialForm is used for the functions whose returnType cannot be computed by input type, but it is complicated,
So I introduce this PR to register them as general function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinchengchenghh @mbasmanova @facebook-github-bot