Remove pointless comparison #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
26 tasks
|
@shayne-fletcher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shayne-fletcher merged this pull request in d4cf652. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the cargo sources the code was comparing the rev specified by the user to the full sha-1 commit hash that cargo locked the git repository to. This would cause reindeer buckify to fail if the user specified a short (7+) hash, a common practice. This check is really rather pointless, as the commit hash is the only thing that truly matters, and if the user did in fact specify an ambiguous/incorrect hash, short or otherwise, cargo would fail to get the correct full sha-1 commit hash anyways, something that reindeer itself need not handle, nor care about, at least in this context.