build script is broken

[tehnerd]

./build_katran is broken

-- Found folly: /usr/local
-- Found fizz: /usr/local
CMake Error at CMakeLists.txt:30 (find_package):
  By not providing "FindGlog.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Glog", but
  CMake did not find one.

  Could not find a package configuration file provided by "Glog" with any of
  the following names:

    GlogConfig.cmake
    glog-config.cmake

  Add the installation prefix of "Glog" to CMAKE_PREFIX_PATH or set
  "Glog_DIR" to a directory containing one of the above files.  If "Glog"
  provides a separate development package or SDK, be sure it has been
  installed.


-- Configuring incomplete, errors occurred!
See also "/home/tehnerd/katran/build/CMakeFiles/CMakeOutput.log".
tehnerd@devubuntu:~/katran$

if i start to install fizz, it became broken on glog (same error) etc etc

what is the blessed way to build open source version of katran?

[udippant]

Thank you for letting us know.
We'll fix the issue and restore the usability of build_katran.sh.

[udippant]

I reworked the build script in 3184a59. Can you try that?

[tehnerd]

on ubuntu 18.04 w/ latest diff from upstream:

/usr/local/include/google/protobuf/stubs/bytestream.h:300:18: error: ‘virtual size_t google::protobuf::ArrayByteSource::Available() const’ marked ‘override’, but does not override
   virtual size_t Available() const override;
                  ^~~~~~~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:302:16: error: ‘virtual void google::protobuf::ArrayByteSource::Skip(size_t)’ marked ‘override’, but does not override
   virtual void Skip(size_t n) override;
                ^~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:327:59: error: expected class-name before ‘{’ token
 class PROTOBUF_EXPORT LimitByteSource : public ByteSource {
                                                           ^
/usr/local/include/google/protobuf/stubs/bytestream.h:330:29: error: expected ‘)’ before ‘*’ token
   LimitByteSource(ByteSource* source, size_t limit);
                             ^
/usr/local/include/google/protobuf/stubs/bytestream.h:333:11: error: ‘StringPiece’ does not name a type
   virtual StringPiece Peek() override;
           ^~~~~~~~~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:338:23: error: ‘ByteSink’ has not been declared
   virtual void CopyTo(ByteSink* sink, size_t n) override;
                       ^~~~~~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:341:3: error: ‘ByteSource’ does not name a type; did you mean ‘LimitByteSource’?
   ByteSource* source_;
   ^~~~~~~~~~
   LimitByteSource
/usr/local/include/google/protobuf/stubs/bytestream.h:332:18: error: ‘virtual size_t google::protobuf::LimitByteSource::Available() const’ marked ‘override’, but does not override
   virtual size_t Available() const override;
                  ^~~~~~~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:334:16: error: ‘virtual void google::protobuf::LimitByteSource::Skip(size_t)’ marked ‘override’, but does not override
   virtual void Skip(size_t n) override;
                ^~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:338:16: error: ‘virtual void google::protobuf::LimitByteSource::CopyTo(int*, size_t)’ marked ‘override’, but does not override
   virtual void CopyTo(ByteSink* sink, size_t n) override;
                ^~~~~~
/usr/local/include/google/protobuf/stubs/bytestream.h:347:1: error: expected declaration before ‘}’ token
 }  // namespace google
 ^
example_grpc/CMakeFiles/katran_server_grpc.dir/build.make:62: recipe for target 'example_grpc/CMakeFiles/katran_server_grpc.dir/katran_server.cpp.o' failed
make[2]: *** [example_grpc/CMakeFiles/katran_server_grpc.dir/katran_server.cpp.o] Error 1
CMakeFiles/Makefile2:2101: recipe for target 'example_grpc/CMakeFiles/katran_server_grpc.dir/all' failed
make[1]: *** [example_grpc/CMakeFiles/katran_server_grpc.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
tehnerd@devubuntu:~/katran$

seems like linking issue w/ grpc - some libs are missed in reworked CMake?

[tehnerd]

if i comment out BUILD_EXAMPLE_GRPC in build_katran - things compiles (core library). also for test_katran path needs to be fixed: instead of "cd "$BUILD_DIR"/katran/lib/tests/" it should be BUILD_DIR/build/katran/lib/tests ( cd _build/build/katran/lib/tests/ && ctest -v ./* works. right now it tries to cd _build/katran/lib/tests/ )

[udippant]

The issue with grpc is strange - I can't repro it on my devserver or even on the travis build triggered by my latest test PR. Can you share the "include path" with verbose make?

The issue with the test path is my mistake - got lost as I was shuffling changes through the ubuntu VM and devserver :). The fix will be landed shortly.

[tehnerd]

re: grpc - yeah looks like something w/ my env. i've tried build in docker (on fresh system w/o any libs installed etc) and it was working just fine

[udippant]

The travis buid script now executes the script build_katran.sh, which is now passing after few fixes I committed earlier today. Reopen if you see any issue with build.