Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Nightly-2023-09-18 #1260

Closed
wants to merge 2 commits into from
Closed

Nightly-2023-09-18 #1260

wants to merge 2 commits into from

Conversation

seanrion
Copy link

@seanrion seanrion commented Jun 28, 2024

Description

Because of this issue(serde-rs/serde#2734), I need to update MIRAI to Nightly-2023-09-18.
And I revised validate.sh because the latest version of triomphe need rustc 1.76 or newer.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh

Checklist:

  • Fork the repo and create your branch from main.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.
  • If you haven't already, complete your CLA here: https://code.facebook.com/cla

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2024
@hermanventer
Copy link
Contributor

This looks fine, but we obviously need to figure out why CI is failing. I'll try to spend some time on updating MIRAI in the coming weeks.

@hermanventer
Copy link
Contributor

I managed to work around the test failures and have ported these changes into PR #1262.

@seanrion
Copy link
Author

seanrion commented Jul 3, 2024

I managed to work around the test failures and have ported these changes into PR #1262.

It looks better. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants