This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Minor datatip fixes #1347
Closed
Minor datatip fixes #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@hansonw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hansonw
added a commit
to facebookarchive/atom-ide-ui
that referenced
this pull request
Oct 19, 2017
Summary: 1) On Windows, modifier keys are also subject to key repeat. So we shouldn't try to repeatedly fetch modifier datatips (#20) 2) We try to blacklist the current mouse position in certain scenarios. However, since moving the mouse clears the blacklist, it's only safe to set this once. `getBufferPosition` forces a layout recalculation so it's expensive! (#94) Closes facebookarchive/nuclide#1347 Reviewed By: wbinnssmith Differential Revision: D6097902 Pulled By: hansonw fbshipit-source-id: c1bd27900a0604d7654abfc0aa15baabf740cf77
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, modifier keys are also subject to key repeat. So we shouldn't try to repeatedly fetch modifier datatips (datatip flickers when keybind held atom-ide-ui#20)
We try to blacklist the current mouse position in certain scenarios. However, since moving the mouse clears the blacklist, it's only safe to set this once.
getBufferPositionforces a layout recalculation so it's expensive! (Optimize DatatipManager._hideOrCancel atom-ide-ui#94)