This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
Fix glog command line arguments on a clean build #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support glog's command line arguments like --logtostderr, it requires gflags.
If gflags is not found, glog will still compile but the command line arguments will be absent.
As glog was created before gflags, that was the case on a clean build.
Note that on subsequent builds gflags already existed, so a second build 'magically' made the command line arguments appear.
Pull Request Template
Title: glog flags like --logtostderr are missing on a clean build
Description:
See facebook/openr#28
Test Plan:
Pull Request Guideline
plausible problem. Further each commit should have the above format.
are impossible to fix once merged. Please rebase your branch on
facebook/openr master instead of merging it.
CONTRIBUTING