This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
import @syntax-background-color from syntax-variables #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thank you! |
facebook-github-bot
pushed a commit
to facebookarchive/nuclide
that referenced
this pull request
Feb 5, 2018
Summary: Import of facebookarchive/atom-ide-ui#160, which is a straightforward fix. Reviewed By: captbaritone Differential Revision: D6893158 fbshipit-source-id: 7bedcce4b1130aaf2f22d4ad799230a7491c3e4c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe
@syntax-background-coloris normally defined inui-variables, soatom-ide-uiseems to throw errors like so:Some themes like
one-darkseem to be importing those syntax variables which is why those themes seem to work fine.This change should make sure that all themes work correctly.